Chore: [AEA-0000] - bump dev container version to 1.4.8#17
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the pinned reusable GitHub Actions workflow SHA used for devcontainer quality checks, intended to align with devcontainer version 1.4.8.
Changes:
- Bump
quality-checks-devcontainer.ymlreusable workflow reference SHA in CI. - Bump the same reusable workflow reference SHA in PR validation.
- Bump the same reusable workflow reference SHA in the release workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updates the reusable quality-checks-devcontainer.yml workflow SHA used during release runs. |
| .github/workflows/pull_request.yml | Updates the reusable quality-checks-devcontainer.yml workflow SHA used on pull requests. |
| .github/workflows/ci.yml | Updates the reusable quality-checks-devcontainer.yml workflow SHA used on pushes to main. |
| quality_checks: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@f3d19a678a725917a5c59cae4d76db621bb7c9c7 | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/quality-checks-devcontainer.yml@8399c1f015c1304e40771cbd8ccc24c7ed48fdbc | ||
| needs: [get_config_values] |
There was a problem hiding this comment.
The PR title/description says it bumps the devcontainer version to 1.4.8, but the repository’s devcontainer definition still sets IMAGE_VERSION to v1.4.2 in .devcontainer/devcontainer.json. If the intent is to upgrade the devcontainer image used by developers, this PR looks incomplete and should update that value (and any other pinned devcontainer image references) to 1.4.8; otherwise, please adjust the PR title/description to reflect that this change is only updating the reusable workflow SHA.
bump dev container version to 1.4.8